Conversation
Allows us to preserve the following properties: - "dumb" `to_json_data` - constructor matches the underlying grafana data model - convenience method for creating columns with styles
Contributor
|
Thanks for looking at it, looks good :) |
Closed
Contributor
|
@jml Thanks! |
Contributor
Author
|
I'll try to do a release next week.
…On Fri, 5 Jan 2018 at 17:47 Mike Bryant ***@***.***> wrote:
@jml <https://github.com/jml> Thanks!
(Would we be able to get a release on Pypi with this included soon?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHq6m_Tq4Ib4nomEVOolCxW3f91CgUoks5tHmAQgaJpZM4RUifq>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes #81 and applies all the review feedback that I couldn't articulate without actually writing the code.
@mikebryant I'd appreciate it if you could take a look.
The new column style classes are there to help "make invalid states unrepresentable". The rest is there to preserve the idea that we have a bottom layer which maps grafana's data model and then a convenience layer on top.