Skip to content

Change ModulePreset to return ModuleError #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2019
Merged

Change ModulePreset to return ModuleError #171

merged 1 commit into from
Sep 25, 2019

Conversation

axic
Copy link
Member

@axic axic commented Sep 25, 2019

Prerequisite to #161.

@axic axic requested a review from jakelang September 25, 2019 18:22
jakelang
jakelang approved these changes Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps in the future, when we establish the new configuration API, we should use a separate error for invalid configurations.

@axic axic merged commit 76108d9 into master Sep 25, 2019
@axic axic deleted the module-preset branch September 25, 2019 18:30
@axic axic mentioned this pull request Sep 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelang jakelang jakelang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @jakelang