-
Notifications
You must be signed in to change notification settings - Fork 63
Open
Description
I used the following in my workflow:
- uses: wagoid/commitlint-github-action@v5
with:
commitDepth: ${{ github.event.pull_request.commits }}
helpURL: http://acme.com/example-url
To my surprise, the workflow logs contained:
Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
This is because my very basic config pulled in the helpUrl
from @commitlint/config-conventional
.
module.exports = { extends: ['@commitlint/config-conventional'] };
To me, this was unexpected because I explicitly told the action to use http://acme.com/example-url
as the helpURL
.
I would propose to flip the sides of the ||
or operator here so the defined inputs are favored over the configuration:
helpUrl: getInput('helpURL') || config.helpUrl,
ivangabriele, SvenStaehs, garysb and jprecuch
Metadata
Metadata
Assignees
Labels
No labels