Refactor: Improve RunCode.luau for proper output and error handling #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors `plugin/src/Tools/RunCode.luau` to:
- Correctly parse the `command` from the input arguments.
- Capture output from `print`, `warn`, `error`, and return values
from the executed code into a single string.
- Track whether an error occurred during `loadstring` or code execution.
- Return a Lua table that conforms to the `CallToolResult` structure
expected by `Main.server.luau` (i.e.,
`{ content = {{ text = output, type = "text" }}, isError = flag }`).
- Enhances safety of code execution by wrapping `chunk()` in a `pcall`
and handling `loadstring` errors.
- Simplifies internal serialization for constructing the output string.
This makes the code execution more robust and ensures its results and
errors are correctly propagated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors
plugin/src/Tools/RunCode.luauto:commandfrom the input arguments.print,warn,error, and return values from the executed code into a single string.loadstringor code execution.CallToolResultstructure expected byMain.server.luau(i.e.,{ content = {{ text = output, type = "text" }}, isError = flag }).chunk()in apcalland handlingloadstringerrors.This makes the code execution more robust and ensures its results and errors are correctly propagated.