-
Notifications
You must be signed in to change notification settings - Fork 39
Edit the list of possible initiatorType values. #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit the list of possible initiatorType values. #418
Conversation
The link to "Early hints" is broken. Will need to export that in html spec to make this PR valid. Bug: w3c#364
I made this edit mostly based on https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/initiatorType, Chromium and WPT test. Decision of the values modified/added here is based on Below is the list of things that are not obvious. And I need some guidance on some of them.
I am not sure if the current text is appropriate, and I am not sure if I should include the "body" value in this list because this is obsolete now.
So I plan to submit a PR that adds a Thanks. |
@noamr : I also filed a PR to fetch: I would add you as a reviewer there but I don't have permission to add reviewers in the whatwg repo. |
@noamr : You mentioned From https://www.w3.org/TR/IFT/, I see the following text: "This document was produced by the Web Fonts Working Group as a Working Draft using the Recommendation track. This document is intended to become a W3C Recommendation." So it looks like it's not yet adopted and implemented. (No wonder I cannot find it in Chromium and WPT). One more consideration: if we report the "initiator type" from IFT, wouldn't something like Thanks. |
Not exactly. The font is the "initiator" of the request. You access a font, and that font "initiates" an IFT request. |
Sorry for the late update. Now this PR is ready for review. I added some text to clarify between "font" and "css". For the "Early-hint" reference, I actually filed PR to export it from html spec. And I found out that I cannot use |
index.html
Outdated
</p> | ||
|
||
<p> | ||
Another example is, the request for a font resource specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Note:" instead of "Another example is,"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! see comment
1. "Another example is" ==> "Note:" 2. Update the reference of "early hints" with the rfc at IETF.
In addition, per domenic@ 's suggestion at whatwg/html#11508, Thanks. |
Update the list.
Bug: #364
Preview | Diff