Skip to content

vxlan: T7468: add VLAN-to-VNI mapping description #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025

Conversation

l0crian1
Copy link
Contributor

@l0crian1 l0crian1 commented Aug 4, 2025

Change summary

Add descriptions per VLAN-to-VNI mapping on VxLAN interfaces

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7468

Related PR(s)

How to test / Smoketest result

Configure a description for the mappings:

set interfaces vxlan vxlan1 parameters external
set interfaces vxlan vxlan1 port '4789'
set interfaces vxlan vxlan1 source-address 10.5.5.5
set interfaces vxlan vxlan1 vlan-to-vni 10 vni '1001'
set interfaces vxlan vxlan1 vlan-to-vni 10 description "Cust-A"
set interfaces vxlan vxlan1 vlan-to-vni 20 vni '1002'
set interfaces vxlan vxlan1 vlan-to-vni 20 description "Cust-B"

Show the config to see the descriptions

vyos@PE2# show interfaces vxlan vxlan1 
 parameters {
     external
 }
 port 4789
 source-address 10.5.5.5
 vlan-to-vni 10 {
     description "Cust-A"
     vni 1001
 }
 vlan-to-vni 20 {
     description "Cust-B"
     vni 1002
 }

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Aug 4, 2025

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Aug 4, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@l0crian1
Copy link
Contributor Author

l0crian1 commented Aug 4, 2025

recheck

1 similar comment
@l0crian1
Copy link
Contributor Author

l0crian1 commented Aug 4, 2025

recheck

Added check for None value from leaf_node_changed when changing VLAN-to-VNI description.
Copy link

github-actions bot commented Aug 4, 2025

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description for vlan-to-vni

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good - nothing to complain

@c-po c-po added the bp/circinus Create automatic backport for circinus label Aug 11, 2025
@c-po c-po merged commit 7b42041 into vyos:current Aug 11, 2025
15 of 16 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus current mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants