Skip to content

Poetry 1.2#271

Merged
vwxyzjn merged 18 commits intomasterfrom
poetry1.2
Oct 3, 2022
Merged

Poetry 1.2#271
vwxyzjn merged 18 commits intomasterfrom
poetry1.2

Conversation

@vwxyzjn
Copy link
Copy Markdown
Owner

@vwxyzjn vwxyzjn commented Sep 10, 2022 •
edited
Loading

Description

Adopting poetry 1.2 support. The locking and adding dependencies are orders of magnitude faster!

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the documentation and previewed the changes via mkdocs serve.
  • I have updated the tests accordingly (if applicable).

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cleanrl ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 4:39PM (UTC)

@vwxyzjn vwxyzjn mentioned this pull request Sep 26, 2022
Closed
4 tasks
@vwxyzjn vwxyzjn requested review from dipamc and dosssman September 27, 2022 19:37
@vwxyzjn vwxyzjn mentioned this pull request Sep 27, 2022
Closed
21 tasks
@vwxyzjn
Copy link
Copy Markdown
Owner Author

vwxyzjn commented Sep 27, 2022

@Dipamc77 and @dosssman this PR is ready for review.

@vwxyzjn vwxyzjn requested a review from kinalmehta September 30, 2022 16:58
@dosssman
Copy link
Copy Markdown
Collaborator

dosssman commented Oct 1, 2022

@vwxyzjn Hello there.
Attempted to test the workflow from scratch by installing poetry 1.2.1 as per their docs using this command: curl -sSL https://install.python-poetry.org | python3 -, but running poetry install in cleanrl directory while under the poetry1.2 branch just hangs.
Is it on my side only ?

$ poetry install
Creating virtualenv cleanrl-iXm2iEAu-py3.9 in /home/d055/.cache/pypoetry/virtualenvs
Installing dependencies from lock file

Package operations: 67 installs, 1 update, 0 removals

  • Installing certifi (2022.6.15.1): Pending...
  • Installing charset-normalizer (2.1.1): Pending...
  • Installing idna (3.3): Pending...
  • Installing pyasn1 (0.4.8): Pending...
  • Installing pyparsing (3.0.9): Pending...
  • Installing urllib3 (1.26.12): Pending...

Or is my luck just that bad today ? 😅

@vwxyzjn
Copy link
Copy Markdown
Owner Author

vwxyzjn commented Oct 2, 2022

@dosssman could you try export PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring? I think it's related to python-poetry/poetry#1917

@dosssman
Copy link
Copy Markdown
Collaborator

dosssman commented Oct 2, 2022

Thanks a lot. This seems to have done the trick now.

dosssman
dosssman approved these changes Oct 2, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dosssman dosssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looking good over here.
Great work.

kinalmehta
kinalmehta approved these changes Oct 3, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kinalmehta kinalmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Test done as follows:

  • Installation successful
  • Did not check if every script ran perfectly. Only tested one for each environment (atari, gym, mujoco, envpool, procgen) and framework (JAX and PyTorch)

LGTM.

@vwxyzjn vwxyzjn merged commit b73e076 into master Oct 3, 2022
ludgerpaehler pushed a commit to ludgerpaehler/koopman-rl that referenced this pull request Jan 13, 2026
@vwxyzjn
Poetry 1.2 (vwxyzjn#271)
3650c43 
* Use poetry 1.2

* update poetry version in CI

* push changes

* fix tests

* update lock files

* update lock files

* update CI

* add cloud integration dependencies

* add isaacgym dependencies

* test change

* update lock files

* update docs

* update poetry version

* update dependencies

* Add a note during installation

* update docs

* quick update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinalmehta kinalmehta kinalmehta approved these changes

@dosssman dosssman dosssman approved these changes

@dipamc dipamc Awaiting requested review from dipamc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vwxyzjn @dosssman @kinalmehta