Fix for noise sampling for the TD3 exploration#260
Merged
vwxyzjn merged 1 commit intovwxyzjn:masterfrom Aug 17, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Author
Collaborator
Author
|
Closes #259 |
Owner
|
Thank you. Given this is a change which does not impact performance, we don’t need to re-run the experiments. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the noise sampling for the TD3 exploration, as pointed out in #259
Types of changes
Checklist:
pre-commit run --all-filespasses (required).I have updated the documentation and previewed the changes viamkdocs serve.I have updated the tests accordingly (if applicable).If you are adding new algorithms or your change could result in performance difference, you may need to (re-)run tracked experiments. See #137 as an example PR.
--capture-videoflag toggled on (required).I have added additional documentation and previewed the changes viamkdocs serve.width=500andheight=300).I have updated the tests accordingly (if applicable).