Skip to content

Auto-upgrade syntax via pyupgrade#158

Merged
vwxyzjn merged 2 commits intomasterfrom
introduce-pyupgrade
Apr 13, 2022
Merged

Auto-upgrade syntax via pyupgrade#158
vwxyzjn merged 2 commits intomasterfrom
introduce-pyupgrade

Conversation

@vwxyzjn
Copy link
Copy Markdown
Owner

@vwxyzjn vwxyzjn commented Apr 10, 2022

Description

This PR automatically upgrades the python syntax via pyupgrade

Types of changes

  • New feature

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the documentation and previewed the changes via mkdocs serve.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/8xLmthC27DiM1cW6WsSNo6cE3o1V
✅ Preview: https://cleanrl-git-introduce-pyupgrade-vwxyzjn.vercel.app

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 10, 2022

@vwxyzjn vwxyzjn requested review from dosssman and yooceii April 10, 2022 21:17
@vwxyzjn vwxyzjn mentioned this pull request Apr 10, 2022
19 tasks
Copy link
Copy Markdown
Collaborator

@dosssman dosssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade.
Despite its deprecation since python2.7, I always wondering why we keep seeing super(, self).init() in open source code. Change is slow but steady.

@vwxyzjn
Copy link
Copy Markdown
Owner Author

vwxyzjn commented Apr 13, 2022

Yep yep. This is a non-performance impacting change. Merging now.

@vwxyzjn vwxyzjn merged commit b403a4b into master Apr 13, 2022
ludgerpaehler pushed a commit to ludgerpaehler/koopman-rl that referenced this pull request Jan 13, 2026
* Auto-upgrade syntax via `pyupgrade`

* Add changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants