Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/FVfp6xKi7pTtnaXPFTa7dhPRKnqL |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…CPU-GPU synchronization.
…cessary CPU-GPU synchronization." This reverts commit 98e0161.
Refactor Check (compatible with the performance in the tracked experiment)I compared the SPS performance of the latest refactor against the old script used in the tracked experiment. I named the old one The following screenshot confirms the refactor does not result in a performance difference (and that we did the refactor correctly — making it faster without impacting sample efficiency) |
There was a problem hiding this comment.
Thank you @yooceii! There is one last thing. Could you also document the meaning of losses/fwd_loss in the docs? Otherwise, everything LGTM. The comment above also confirms the refactor was only beneficial (reducing GPU memory, making the script about 50%-100% faster)


Description
Closes #127
Types of changes
Checklist:
pre-commit run --all-filespasses (required).mkdocs serve.If you are adding new algorithms or your change could result in performance difference, you may need to (re-)run tracked experiments. See #137 as an example PR.
--capture-videoflag toggled on (required).mkdocs serve.width=500andheight=300).