Skip to content

feat($theme-default): inform screen readers link opens in new tab/window (fix #2601) #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2020
Merged

feat($theme-default): inform screen readers link opens in new tab/window (fix #2601) #2603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2599798
feat($theme-default): inform screen readers link opens in new tab/window
d-pollard Sep 9, 2020
2595976
feat($theme-default): add a11y attributess to OutboundLink icon
d-pollard Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/@vuepress/core/lib/client/components/OutboundLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
<template functional>
<template>
<svg
class="icon outbound"
xmlns="http://www.w3.org/2000/svg"
aria-hidden="true"
aria-labelledby="outbound-link-title"
role="img"
focusable="false"
x="0px"
y="0px"
viewBox="0 0 100 100"
width="15"
height="15"
>
<title id="outbound-link-title">{{ openInNewWindowTitle }}</title>
<path
fill="currentColor"
d="M18.8,85.1h56l0,0c2.2,0,4-1.8,4-4v-32h-8v28h-48v-48h28v-8h-32l0,0c-2.2,0-4,1.8-4,4v56C14.8,83.3,16.6,85.1,18.8,85.1z"
Expand All @@ -20,6 +23,16 @@
</svg>
</template>

<script>
export default {
computed: {
openInNewWindowTitle () {
return this.$themeLocaleConfig.openNewWindowText || '(opens new window)'
}
}
}
</script>

<style>
.icon.outbound {
color: #aaa;
Expand Down