fix($theme-default): regression of custom container default title #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kefranabg
approved these changes
Sep 21, 2019
There was a problem hiding this comment.
Awesome @meteorlxy, nice catch. It deserved a patch release, @f3ltron what do you think?
|
Oh, BTW, I didn't pay much attention on vuepress for months. What happened to the maintainer team? |
|
@ulivz made a recruitment announcement |
flozero
approved these changes
Sep 21, 2019
|
Hey @meteorlxy, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
|
@kefranabg Interesting I used to be an active contributor, but do not have so much time these days. Happy to see the new team. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
V0
Regression
After this patch
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
Other information:
This regression was introduced by #1462:
https://github.com/vuejs/vuepress/pull/1462/files#diff-89632cc75524a98d72bf12ae77132560R24-R41