Skip to content

fix($plugin-pagination): better function transfer (close: #1338) #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

shigma
Copy link
Collaborator

@shigma shigma commented Feb 25, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

It look's awesome but we need to resolve conflicts and add test i think

@flozero flozero self-assigned this Sep 5, 2019
@flozero flozero added complexity: medium Medium complexity status: core team assigned Core team member assigned topic: config Relates to VuePress config type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@ulivz
Copy link
Member

ulivz commented Sep 23, 2019

Same here, the pagination plugin has been merged into the new official blog plugin, please continue discussion here.

@ulivz ulivz closed this Sep 23, 2019
@flozero flozero deleted the plugin-pagination-function-transfer branch January 29, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: medium Medium complexity status: core team assigned Core team member assigned topic: config Relates to VuePress config type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants