Fixed transitions on some Android 4.1 devices #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some devices (tested on a Samsung Galaxy S2), Android 4.1 is erroneously reporting to support unprefixed transitions events, while it’s in fact not implemented. The solution is to test for the prefixed version first. The WebKit-prefixed event has been moved on top of the tested events, and while the Object properties order is not guaranteed in JavaScript (ES3, section 4.3.3), it is the case in the targeted browser.
yyx990803
added a commit
that referenced
this pull request
Apr 29, 2014
Fixed transitions on some Android 4.1 devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some devices (tested on a Samsung Galaxy S2), the Android 4.1 browser erroneously reports to support unprefixed transitions events, while it’s in fact not implemented.
The solution is to test for the prefixed version first. The WebKit-prefixed event has been moved on top of the tested events, and while the Object properties order is not guaranteed in JavaScript (ES3, section 4.3.3), it is the case in the targeted browser.
More information:
Modernizr/Modernizr#897
https://bugs.dojotoolkit.org/ticket/17164