fix: ensure new webpack5 generator property in rules passes ruleset checks (v16) #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
changed the title
haoqunjiang
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack 5 has a new property in rule definitions called
generator- we need to account for that in the rule validiations we have in place.Note this is for vue-loader 16, targeting Vue 3. Matching PR for v15: #1753
Tests
I wasn't able to test this with v16, as the repo is locked to webpack v4, and switching tempararily to webpack 5 breaks everything as the type imports for webpack no longer work/match.
Since I could verify the change on the other PR for v15, this should be safe to merge.
close #1729