Skip to content

feat: support webpack 5 hooks #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2019
Merged

feat: support webpack 5 hooks #1469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acc9874
feat: support webpack 5 hooks
clarkdo Jan 8, 2019
51ae9ee
refactor: code review changes
clarkdo Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ class VueLoaderPlugin {
if (compiler.hooks) {
// webpack 4
compiler.hooks.compilation.tap(id, compilation => {
compilation.hooks.normalModuleLoader.tap(id, loaderContext => {
let { normalModuleLoader } = compilation.hooks;
if (!normalModuleLoader) {
// webpack 5
normalModuleLoader = require('webpack/lib/NormalModule').getCompilationHooks(compilation).loader
}
normalModuleLoader.tap(id, loaderContext => {
loaderContext[NS] = true
})
})
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"peerDependencies": {
"css-loader": "*",
"webpack": "^4.1.0"
"webpack": "^4.1.0 || ^5.0.0"
},
"dependencies": {
"@vue/component-compiler-utils": "^2.4.0",
Expand Down