Skip to content

fix(timeline): Reset layer status when selected layer is hidden in timeline #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix(timeline): Reset layer status when selected layer is hidden in timeline #2109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/app-frontend/src/features/timeline/TimelineEventList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,8 @@ export default defineComponent({
// Auto bottom scroll

function scrollToBottom () {
if (!scroller.value) return

requestAnimationFrame(() => {
if (!scroller.value) return
const scrollerEl = scroller.value.$el
scrollerEl.scrollTop = scrollerEl.scrollHeight
})
Expand Down
13 changes: 13 additions & 0 deletions packages/app-frontend/src/features/timeline/composable/layers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,22 @@ export function useLayers () {
return list.includes(layer.id)
}

function resetSelectedStatus () {
selectedLayer.value = null
inspectedEvent.value = null
selectedEvent.value = null
hoverLayerId.value = null
setStorage('selected-layer-id', '')
}

function setLayerHidden (layer: Layer, hidden: boolean) {
const list = getHiddenLayers(currentAppId.value)
const index = list.indexOf(layer.id)

if (selectedLayer.value === layer) {
resetSelectedStatus()
}

if (hidden && index === -1) {
list.push(layer.id)
} else if (!hidden && index !== -1) {
Expand Down