Skip to content

ci: add lint job #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ci: add lint job #280

wants to merge 2 commits into from

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Oct 14, 2019

Run prettier on more supported files.

Add CI job to check style, avoid #227

@fisker fisker closed this Oct 14, 2019
@fisker fisker reopened this Oct 14, 2019
@fisker
Copy link
Contributor Author

fisker commented Oct 14, 2019 •
edited
Loading

I forgot that

  1. parser in .prettierc is not required until v1.16.0
  2. --check also not supported in v1.14.0

Should we update the prettier version (may format ts differently fisker@2d0999c) or restore .prettierrc & remove --check

@yyx990803
Copy link
Member

I don't really think this is necessary... let's not spend too much time on yak shaving.

@yyx990803 yyx990803 closed this Oct 14, 2019
yyx990803 pushed a commit that referenced this pull request Nov 11, 2024
@LittleSound
test(runtime-vapor): fix shallowRef in v-for (#280)
5f6cd32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @yyx990803