Skip to content

fix(v-model): array checkbox #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(v-model): array checkbox #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/runtime-dom/src/directives/vModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export const vModelCheckbox: Directive<HTMLInputElement> = {
if (i > -1) {
assign([...modelValue.slice(0, i), ...modelValue.slice(i + 1)])
} else {
assign(modelValue.concat(elementValue))
assign(modelValue.concat([elementValue]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you prefer creating an array?
The previous version is correct.

concat

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... you are right.
the code of vue2.x misled me. 😂

}
} else {
assign(el.checked)
Expand Down