Skip to content

refactor(componentProxy): simplify proxy handling #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2019
Merged

refactor(componentProxy): simplify proxy handling #214

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2be456f
refactor(componentProxy): simplify proxy handling
dsseng Oct 11, 2019
276968c
style(componentProxy): refactor to match requested changes
dsseng Oct 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions packages/runtime-core/src/componentProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,18 @@ export type ComponentPublicInstance<
ExtractComputedReturns<C> &
M

const proxyHandlers = {
$data: 'data',
$props: 'propsProxy',
$attrs: 'attrs',
$slots: 'slots',
$refs: 'refs',
$parent: 'parent',
$root: 'root',
$emit: 'emit',
$options: 'type'
}

export const PublicInstanceProxyHandlers = {
get(target: ComponentInternalInstance, key: string) {
const { renderContext, data, props, propsProxy } = target
Expand All @@ -42,28 +54,12 @@ export const PublicInstanceProxyHandlers = {
// return the value from propsProxy for ref unwrapping and readonly
return propsProxy![key]
} else {
// TODO simplify this?
if (hasOwn(proxyHandlers, key)) {
return target[proxyHandlers[key]]
}
switch (key) {
case '$data':
return data
case '$props':
return propsProxy
case '$attrs':
return target.attrs
case '$slots':
return target.slots
case '$refs':
return target.refs
case '$parent':
return target.parent
case '$root':
return target.root
case '$emit':
return target.emit
case '$el':
return target.vnode.el
case '$options':
return target.type
default:
// methods are only exposed when options are supported
if (__FEATURE_OPTIONS__) {
Expand Down