The system automatically updates the time, resulting in event loss #13494
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ausing registered listeners to become invalid When the system automatically updates the time to the time before assigning the value to 'invoker. attached', 'e.vts<=invoker. attached' will cause the function to always jump out, resulting in listening failure
WalkthroughThe code replaces all instances of Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/runtime-dom/src/modules/events.ts (1)
86-92: Adopt monotonic timer for invoker attachment timestamps
The newgetNowcorrectly usesperformance.now()with a per-tick cache to replaceDate.now(), ensuring monotonic behavior and reducing calls.Consider splitting the comma‐operator expression into two statements for clarity:
- const getNow = () => - cachedNow || (p.then(() => (cachedNow = 0)), (cachedNow = performance.now())) + const getNow = () => { + if (cachedNow) return cachedNow + p.then(() => { cachedNow = 0 }) + cachedNow = performance.now() + return cachedNow + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/runtime-dom/src/modules/events.ts(2 hunks)
🔇 Additional comments (1)
packages/runtime-dom/src/modules/events.ts (1)
110-113: Assign monotonic timestamps to events on first dispatch
ReplacingDate.now()withperformance.now()fore._vtsguarantees that event timestamps aren’t affected by system clock changes. Implementation is correct.
edison1105
added
ready to merge
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the system automatically updates the time to the time before assigning the value to 'invoker. attached', 'e.vts<=invoker. attached' will cause the function to always jump out, resulting in listening failure
demo
Summary by CodeRabbit
Date.now()toperformance.now()for all event-related timing.