Skip to content

fix(runtime-core): handle validate prop check edge case #12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12234

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 23, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12240

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12240

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12240

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12240

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12240

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12240

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12240

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12240

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12240

vue

pnpm add https://pkg.pr.new/vue@12240

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12240

commit: 8e6a77d

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Oct 23, 2024
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of existing PRs that seem to be trying to solve the same problem: #8539 and #7809. I'm not entirely sure which approach is best, perhaps a combination?

Comment on lines +800 to +801
} else if (isSymbol(value)) {
return stringifySymbol(value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this check needs to come first, otherwise it'll still fail when a Symbol is passed for a prop with type: String.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop type inference for typeof Symbol() is incorrect and breaks Vue runtime checks
2 participants