Fix VariableFn<V> type returns Object instead of V #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VariableFn<V>
type incorrectly returns anyObject
type, rather than the type specified byV
. This is a small change but has a high impact on type correctness.This resulted in an easily preventable typing bug in our app. Here is a simplified example:
This means that the
variables
key of a few important things don't actually checkV
variables
type:ApolloVueSubscribeToMoreOptions<V>
VueApolloQueryOptions<V, R>
VueApolloMutationOptions<V, R>
VueApolloSubscriptionOptions<V, R>