Skip to content

Node 10 Compatibility + Added vue-multiselect noResult slot option #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2018

Conversation

qkdreyer
Copy link
Contributor

@qkdreyer qkdreyer commented Jun 19, 2018

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
  • Other information:

Fixes #457
Fixes #380

@qkdreyer qkdreyer changed the title Fixed #380 - Added vue-multiselect noResult slot option Node 10 Compatibility + Added vue-multiselect noResult slot option Jun 19, 2018
@zoul0813
Copy link
Member

@lionel-bijaoui as you're actively working on merging a PR, can you review this real quick to make sure we won't have any conflicts ... don't want to make your life any more complicated than it needs to be.

@qkdreyer
Copy link
Contributor Author

It shouldn't be hard to resolve any conflitcs since it's only one package version modification and 2 lines added :)

@lionel-bijaoui
Copy link
Member

I'm not too worried, but please, let me do my merge first, then this one.

@lionel-bijaoui lionel-bijaoui merged commit 3d7794f into vue-generators:master Jun 27, 2018
@qkdreyer
Copy link
Contributor Author

qkdreyer commented Jun 27, 2018

Do you know when it will be released ?

@lionel-bijaoui
Copy link
Member

@qkdreyer I don't know, I hope soon

@zoul0813
Copy link
Member

@lionel-bijaoui I can release it now, if you think that's OK? I think the dep and dev tool work you did is enough to call this a "v2.3.0 release" ... ?

@lionel-bijaoui
Copy link
Member

Right now my problem is that Travis fail, but locally all the test are green. I don't understand...

@zoul0813
Copy link
Member

I just grabbed the latest code, and ran the tests ... I get a bunch of errors output, but the test suite says they ran successfully. Want me to open a new issue so we can track problems with releasing v2.3.0?

@lionel-bijaoui
Copy link
Member

I get weird outputs, but nothing like what Travis has.
Yes please 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation is broken due to broken nan package Set slot with VueMultiSelect
5 participants