#112 Get rid of Vue dependency in the code. #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve output bundle size by removing Vue dep and using moment.min.js
Reduced bundle size from 402kb to 176kb.
I think it's better to check if
vue-multi-select
is registered globally rather than checking if it's present in the window. Most of the time you register vue components withVue.component...
globally and don't necessarily put them in the window.