Qualify ptr to fix Windows build regression
#174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes vorner#173 in `signal-hook-registry`. Since version 1.4.4, `ptr` is used unqualified. This works on Unix-like systems, but it is not found on Windows. Qualifying it as `core::ptr` works.
|
Thank you. Though, I've fixed in somewhat different way. |
|
Thanks! The change you made in f31d712 is actually much better than what I had suggested here. I'm not sure why I didn't notice that the problem was caused by the import being conditional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
Since
signal-hook-registryversion 1.4.4,ptris used unqualified. This works on Unix-like systems, but as shown in #173, it is not found on Windows. Qualifying it ascore::ptrworks.This restores the ability to build on Windows.