Skip to content

Conversation

QuyLX2
Copy link

@QuyLX2 QuyLX2 commented Mar 25, 2025

  • Remove all Docker related files (Dockerfile, docker-compose files)

  • Remove all test files (*.spec.ts) and test configurations

  • Update package.json to remove test dependencies and scripts

  • Update tsconfig.build.json to remove test exclusions

Pull Request types

  • 🐛 Bug Fix
  • 👍 Improvement
  • ✨ New Feature
  • 🎉 Release
  • ♻️ Refactoring
  • 🚿 Refactoring (Remove functions)
  • 💚 Refactoring (Test or CI)
  • 👕 Fix (Lint)
  • 🆙 Update (Dependency packages)
  • 🚀 Improvement (Performance)
  • 👮 Improvement (Security)
  • 🔒 Restriction (Restrict new feature)
  • 👾 Others

Description

Checklist

  • 1. Build successfully on local
  • 2. Format all code files included in the PR
  • 3. No more unconfirmed specs in the PR
  • 4. Tested the normal case and error cases following specs
  • 5. Is there a refactor to the old code? If yes, have you tested the old function and noted the impact yet?
  • 6. Loops have a set length and correct termination conditions
  • 7. There aren't any redundant or duplicate codes in PR (clean code)
  • 8. There aren't any hard-coded in the code in PR
  • 9. Optimization logic handling and optimizations SQL (for example, don't get redundant data or add an index to optimize performance, query only necessary fields...)
  • 10. Update issue status and add PR link to the issue

Evidence

(Screenshot or Video)

Discussion

- Remove all Docker related files (Dockerfile, docker-compose files)

- Remove all test files (*.spec.ts) and test configurations

- Update package.json to remove test dependencies and scripts

- Update tsconfig.build.json to remove test exclusions
@lamngockhuong
Copy link
Contributor

Sorry, I can not merge this PR.
This boilerplate needs to implement Unit test, and we are going to plan to write unit test fully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants