Skip to content

[Model] Add missing prefix to glm4_1v #22716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2025
Merged

[Model] Add missing prefix to glm4_1v #22716

merged 5 commits into from
Aug 13, 2025

Conversation

zRzRzRzRzRzRzR
Copy link
Contributor

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR commented Aug 12, 2025 •
edited by DarkLight1337
Loading

Patch prepared for FP8.

@zRzRzRzRzRzRzR
add prefix
47e123d 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR marked this pull request as draft August 12, 2025 07:23
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces prefixing capabilities to several modules in glm4_1v.py, which is a good step for better weight namespacing, especially for quantization. My main feedback is about an inconsistency in Glm4vPatchMerger, where one of the parallel linear layers (self.proj) was not updated to use the new prefix parameter. This could lead to issues with weight loading or quantization. Please see the detailed comment.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR marked this pull request as ready for review August 12, 2025 07:35
@zRzRzRzRzRzRzR
add prefix for proj
4347134 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
@zRzRzRzRzRzRzR
add prefix for proj
e6bb03c 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
@jeejeelee jeejeelee changed the title add prefix [Model] Add missing prefix to glm4_1v Aug 12, 2025
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 12, 2025
@jeejeelee jeejeelee enabled auto-merge (squash) August 12, 2025 08:20
@DarkLight1337 DarkLight1337 mentioned this pull request Aug 12, 2025
Open
1 task
@DarkLight1337
Copy link
Member

Seems that the original issue is not solved yet

@zRzRzRzRzRzRzR
Copy link
Contributor Author

This issue does not appear to be caused by unsupported official models.

@DarkLight1337
Copy link
Member

Got it, let's merge this first then

@vllm-bot vllm-bot merged commit 9e7e5ba into vllm-project:main Aug 13, 2025
38 of 44 checks passed
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
@zRzRzRzRzRzRzR @taneem-ibrahim
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
6e7e761 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025
@zRzRzRzRzRzRzR @BoyuanFeng
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
392cb7b 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
Signed-off-by: Boyuan Feng <[email protected]>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@zRzRzRzRzRzRzR @diegocastanibm
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
991626d 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 18, 2025
@zRzRzRzRzRzRzR
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
ba02831 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
@zRzRzRzRzRzRzR @yiliu30
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
0362c18 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
@zRzRzRzRzRzRzR @divakar-amd
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
ee22b08 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
HeJunyan added a commit to HeJunyan/vllm-fork that referenced this pull request Aug 20, 2025
@HeJunyan
[Model] Add missing prefix to glm4_1v vllm-project#22716
2721f32
Gh0u1L5 pushed a commit to Gh0u1L5/vllm that referenced this pull request Aug 21, 2025
@zRzRzRzRzRzRzR @Gh0u1L5
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
11e4097 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@zRzRzRzRzRzRzR @epwalsh
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
08c39b8 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR deleted the glm-45 branch August 28, 2025 09:35
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@zRzRzRzRzRzRzR @amd-xiaoyu12
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
6795a3c 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@zRzRzRzRzRzRzR @amd-xiaoyu12
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
fdd292f 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@zRzRzRzRzRzRzR @zhewenl
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
59a1690 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
dumb0002 pushed a commit to dumb0002/vllm that referenced this pull request Aug 28, 2025
@zRzRzRzRzRzRzR @dumb0002
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
8727a4a 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@zRzRzRzRzRzRzR @googlercolin
[Model] Add missing prefix to glm4_1v (vllm-project#22716)
cfaaac6 
Signed-off-by: zRzRzRzRzRzRzR <[email protected]>
HeJunyan added a commit to HeJunyan/vllm-fork that referenced this pull request Sep 22, 2025
@HeJunyan
[Model] Add missing prefix to glm4_1v vllm-project#22716
bd793a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zRzRzRzRzRzRzR @DarkLight1337 @jeejeelee @vllm-bot