Skip to content

Conversation

@david-pureal
Copy link

@david-pureal david-pureal commented Jul 13, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Fix exception (PIL.UnidentifiedImageError) when loading AVIF images.

Test Plan

pytest -s -v tests/multimodal/test_image.py

Test Result

Signed-off-by: daweidang <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @david-pureal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where AVIF images could not be loaded, resulting in an UnidentifiedImageError. My changes integrate support for the AVIF image format by adding a necessary plugin and including a test to validate its functionality. This ensures the application can now seamlessly handle AVIF images.

Highlights

  • Dependency Addition: I've added pillow-avif-plugin to the project's common and test requirements. This new dependency is crucial for enabling AVIF image support within the application.
  • AVIF Support Integration: To activate the newly added plugin, I've included an import statement for pillow_avif in vllm/multimodal/image.py. This ensures that the Pillow library can correctly identify and load AVIF formatted images.
  • New Test Case: I've introduced a new test test_load_avif in tests/multimodal/test_image.py. This test verifies that AVIF images can be loaded successfully, preventing PIL.UnidentifiedImageError exceptions and confirming the integration works as expected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added ci/build multi-modality Related to multi-modality (#4194) labels Jul 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds support for AVIF images by including the pillow-avif-plugin dependency and an associated test. The changes are well-targeted. My feedback includes suggestions for improving dependency versioning for better stability and refactoring the new test to be more idiomatic and robust, which will enhance the project's long-term maintainability.

daweidang added 2 commits July 14, 2025 01:13
@DarkLight1337
Copy link
Member

The referenced PR python-pillow/Pillow#5201 has been merged into Pillow already, so I think you just have to upgrade your version of Pillow

@david-pureal
Copy link
Author

david-pureal commented Jul 14, 2025

The referenced PR python-pillow/Pillow#5201 has been merged into Pillow already, so I think you just have to upgrade your version of Pillow

Confirmed: Latest Pillow (11.3) supports AVIF, but vLLM v0.9.2 still includes older Pillow 10.4.2 without AVIF support. Requires dependency update. Should I update the requirements or just close this PR?

@DarkLight1337
Copy link
Member

Since vLLM doesn't lock the user version of Pillow, the next vLLM release should automatically include the latest Pillow. You can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build multi-modality Related to multi-modality (#4194)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants