-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Improve conversion from dataclass configs to argparse arguments #17303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Harry Mellor <[email protected]>
Can you add some tests to verify this? |
Signed-off-by: Harry Mellor <[email protected]>
I've added tests for every helper function used to convert dataclass configs into argparse arguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM now!
…-project#17303) Signed-off-by: Harry Mellor <[email protected]>
…-project#17303) Signed-off-by: Harry Mellor <[email protected]>
…-project#17303) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Mu Huai <[email protected]>
…-project#17303) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
…-project#17303) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: minpeter <[email protected]>
optional_x
has been replaced withoptional_type(x)
so we don't need different methods for different typesnullabke_kvs
tuple
args can now have specific number of values if the config does not useEllipsis
list
args are also supported now"None"
is added as a choice if the arg has choicesThis was originally done in #17130, but has been split into this PR to reduce the review load on the original.