gg: fix X11 C aliases for gg import - #27586
Merged
Merged
Conversation
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #27584
This restores V1 compatibility for importing
ggon Linux after the X11 Sokol aliases were changed to preserve C typedef names for V3.The fix defines the missing X11
C.*scalar aliases locally, while keeping the public aliases backed byC.XID,C.Atom,C.Window,C.KeySym, etc. This lets V1 type-check the X11 scalar operations again without reverting the V3 C ABI work.A focused regression test was added for the user-facing case: a minimal program importing
gg.Validation
./v test vlib/v/tests/gg_import_check_test.v./v test vlib/v3/tests/x11_source_abi_alias_codegen_test.v./v fmt -verify vlib/sokol/sapp/sapp_linux.c.v vlib/sokol/sapp/sapp_x11_linux.v vlib/v/tests/project_issue_27584_gg_import_check_test.v./v -check vlib/v/tests/skip_unused/gg_code.vv./v test vlib/v/tests/fixed_array_update_c_struct_alias_test.v./v -silent test vlib/gg/examples/tetris/tetris.v: compile + short runexamples/tetris/tetris.v: compile + short run