cgen: route integer interpolation through str_intp - #27575
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6b16b7369
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a6b16b7 to
59f02e4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59f02e4058
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
59f02e4 to
8ab73ce
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ab73ce4e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8ab73ce to
6c26e86
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c26e865e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6c26e86 to
77f32f2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77f32f24ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
77f32f2 to
34cbfff
Compare
Fixes #27574
Summary:
str_intpoutside builtin internals, avoiding theint_str+string_plus_manylowering.markusedin sync for direct and generic string interpolation sostr_intpruntime helpers stay available when needed..str()/auto-str helper dependencies fors-formatted operands when another operand forces runtime interpolation.${2147483648}.sformatting on the existing simple stringification path.os+-skip-unusedhelper retention case, mixed integer plus auto-str operands, the large integer literal path, and grouped aggregate smartcasts.Tests:
./v -g -keepc -o ./vnew cmd/v./vnew -silent vlib/v/compiler_errors_test.v./vnew -silent test -run-only test_skip_unused_runtime_integer_interpolation_marks_auto_str_operand vlib/v/gen/c/coutput_test.v./vnew -silent test -run-only test_skip_unused_aggregate_smartcast_integer_interpolation_uses_simple_path vlib/v/gen/c/coutput_test.v./vnew -silent test -run-only test_skip_unused_os_integer_interpolation_keeps_str_intp_runtime vlib/v/gen/c/coutput_test.v./vnew -silent test -run-only test_c_must_have_files vlib/v/gen/c/coutput_test.v./vnew -skip-unused run vlib/v/gen/c/testdata/string_interpolation_simple_optimization.vv./vnew run vlib/v/checker/tests/run/comptime_ident_is_type.vv./vnew -silent test vlib/v/tests/builtin_strings_and_interpolation/Notes:
./vnew -silent vlib/v/gen/c/coutput_test.vrun still hit an unrelatedtranslated_module.vvmismatch with empty output instead ofresult: 104../vnew -silent test vlib/v/run was stopped after unrelated failures from an untrackedcmd/v2/_tmp_map_empty_raw.vparser fixture pickup and tcc fallback warning output pollution.coutput_test.vshares temp directories and process cwd state across tests; the relevant coutput checks were rerun sequentially withtest -run-onlyand passed.