Fix show file blob fn with an alternative algorithm #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! Can you also please add a small test? Can be generated with AI. Needs to http.get a file blog url and ensure it contains certain text. |
|
Well, yes, I think I can. It will take some time to think it over, though. My pleasure. |
|
Yes, you can remove commented out code. If it is needed, it can be recovered from the history. Better to keep only "live" code, instead of having to scroll past lots of commented code. |
|
@medvednikov Ready. Please have a look and check if it can be merged now. |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation seems to me as a compromise between performance and usability:
I hope the changes may help the project. The branch goal is to take into account the considerations discussed here: #282