-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: encode projectName in browser client URL #9523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheremet-va
merged 4 commits into
vitest-dev:main
from
dkkim0122:fix/browser-client-url-encoding
Jan 28, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4c47fdc
fix: correctly encode project name in browser client URL (#9242)
dkkim0122 f533cc8
test(browser): add integration test for project name encoding
dkkim0122 c56b9b6
test(browser): improve project name encoding integration test
dkkim0122 ef3223d
test(browser): refactor project name encoding test to be provider-agn…
dkkim0122 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' | ||
|
|
||
| describe('Browser Client URL Encoding', () => { | ||
| beforeEach(() => { | ||
| vi.resetModules() | ||
|
|
||
| vi.stubGlobal('window', { | ||
| __vitest_browser_runner__: { | ||
| type: 'tester', | ||
| sessionId: 'session-123', | ||
| testerId: 'tester-456', | ||
| method: 'run', | ||
| config: { | ||
| name: 'Components & Hooks', | ||
| }, | ||
| }, | ||
| VITEST_API_TOKEN: 'token-789', | ||
| }) | ||
|
|
||
| vi.stubGlobal('location', { | ||
| protocol: 'http:', | ||
| hostname: 'localhost', | ||
| port: '5173', | ||
| }) | ||
|
|
||
| vi.stubGlobal('WebSocket', class MockWebSocket { | ||
| constructor(public url: string) {} | ||
| addEventListener() {} | ||
| send() {} | ||
| close() {} | ||
| }) | ||
| }) | ||
|
|
||
| afterEach(() => { | ||
| vi.unstubAllGlobals() | ||
| }) | ||
|
|
||
| it('should encode project name with ampersand in ENTRY_URL', async () => { | ||
| const { ENTRY_URL } = await import('../../../packages/browser/src/client/client') | ||
|
|
||
| const url = new URL(ENTRY_URL) | ||
|
|
||
| expect(ENTRY_URL).toContain('projectName=Components%20%26%20Hooks') | ||
|
|
||
| expect(url.searchParams.get('projectName')).toBe('Components & Hooks') | ||
|
|
||
| expect(url.searchParams.get('type')).toBe('tester') | ||
| expect(url.searchParams.get('sessionId')).toBe('session-123') | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a good test because it mocks everything. Tests in
browserrun in Node.js and spawn Vitest process that runs the browser. You can look at other examples. Just add a new test with a project name that would fail previously and test that basic test ran correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to an integration test. Is this similar to what you expected?