-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Track and display expectedly failed tests (.fails) in UI and CLI #9476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e7a4317
Initial plan
Copilot 590da94
Add expected fail tracking to CLI and UI reporters
Copilot d7be6a8
Update getStateString to track expected failures in base reporter
Copilot 7df9d08
Remove type casts and use proper type narrowing for fails property
Copilot 6bafe40
Merge branch 'main' into copilot/add-known-failing-tests-support
sheremet-va File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -149,15 +149,29 @@ export function getStateString( | |
| return c.dim(`no ${name}`) | ||
| } | ||
|
|
||
| const passed = tasks.reduce((acc, i) => i.result?.state === 'pass' ? acc + 1 : acc, 0) | ||
| const passed = tasks.reduce((acc, i) => { | ||
| // Exclude expected failures from passed count | ||
| if (i.result?.state === 'pass' && i.type === 'test' && (i as any).fails) { | ||
| return acc | ||
| } | ||
| return i.result?.state === 'pass' ? acc + 1 : acc | ||
| }, 0) | ||
| const failed = tasks.reduce((acc, i) => i.result?.state === 'fail' ? acc + 1 : acc, 0) | ||
| const skipped = tasks.reduce((acc, i) => i.mode === 'skip' ? acc + 1 : acc, 0) | ||
| const todo = tasks.reduce((acc, i) => i.mode === 'todo' ? acc + 1 : acc, 0) | ||
| const expectedFail = tasks.reduce((acc, i) => { | ||
| // Count tests that are marked as .fails and passed (which means they failed as expected) | ||
| if (i.result?.state === 'pass' && i.type === 'test' && (i as any).fails) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't cast
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 7df9d08. Now using proper type narrowing - TypeScript infers the correct type after checking |
||
| return acc + 1 | ||
| } | ||
| return acc | ||
| }, 0) | ||
|
|
||
| return ( | ||
| [ | ||
| failed ? c.bold(c.red(`${failed} failed`)) : null, | ||
| passed ? c.bold(c.green(`${passed} passed`)) : null, | ||
| expectedFail ? c.cyan(`${expectedFail} expected fail`) : null, | ||
| skipped ? c.yellow(`${skipped} skipped`) : null, | ||
| todo ? c.gray(`${todo} todo`) : null, | ||
| ] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't cast
as anyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7df9d08. Now using proper type narrowing - TypeScript infers the correct type after checking
i.type === 'test'.