docs(fix): fix some wcag-aa color contrast issues#9468
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| */ | ||
| --color-grey: #867e8e; | ||
| /* TODO: code block (remove this once fixed at void0 theme) */ | ||
| --vp-code-color: #007d38; |
There was a problem hiding this comment.
moving this to :root[data-theme="light"][data-variant="vitest"] { doesn't work, this is why I also add --vp-code-color: var(--vp-c-brand-1); at :root.dark:not([data-theme])[data-variant="vitest"], :root[data-theme="dark"][data-variant="vitest"] {; from time to time, changing styles.css doesn't reload, I need to restart VP dev server
/cc @brc_dd
There was a problem hiding this comment.
--vp-code-color is --vp-c-brand-1 which is --color-brand by default
There was a problem hiding this comment.
added :root[data-variant="vitest"]:not(.dark):not([data-theme="light"]) (missing entry, we use class="dark" for dark theme but no class for light theme) and moved the --vp-code-color there
|
Found some wcag-aa color contrast issues on light theme:
We can solve these issues in a separate PR. |
|
I feel like it makes more sense to fix this in the Void0 theme (at least what's in docs/.vitepress/theme/styles.css) |
|
Or I guess only the gray color should be fixed in v0. Let's merge it for now |
Description
This PR includes fixes for:
--color-greyfor light theme (home page)--color-grey for light theme screenshots
footer with this PR

footer without this PR

features item screenshots with this PR
features colors

color contrast

code blocks screenshots
code blocks with this PR

code blocks without this PR

Resolves #issue-number
I will do a new full review tomorrow (this can be merged)...
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.