Skip to content

docs(fix): fix some wcag-aa color contrast issues#9468

Merged
sheremet-va merged 4 commits intomainfrom
userquin/docs-fix-wcag-aa-colors
Jan 21, 2026
Merged

docs(fix): fix some wcag-aa color contrast issues#9468
sheremet-va merged 4 commits intomainfrom
userquin/docs-fix-wcag-aa-colors

Conversation

@userquin
Copy link
Copy Markdown
Member

@userquin userquin commented Jan 15, 2026

Description

This PR includes fixes for:

  • --color-grey for light theme (home page)
  • features item colors to use brand theme colors on icons and texts (/guide/features page state animation colors)
  • code blocks on light theme: using void0 theme colors
--color-grey for light theme screenshots

footer with this PR
image

footer without this PR
image

features item screenshots with this PR

features colors
image

color contrast
image

code blocks screenshots

code blocks with this PR
image

code blocks without this PR
image

Resolves #issue-number

I will do a new full review tomorrow (this can be merged)...

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 16, 2026

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 1120e5d
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69697f69ae0dc0000886b878
😎 Deploy Preview https://deploy-preview-9468--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@userquin userquin marked this pull request as ready for review January 16, 2026 00:01
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 16, 2026

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit d7d088d
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/696a55f788be7b00086d37fd
😎 Deploy Preview https://deploy-preview-9468--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread docs/.vitepress/theme/styles.css Outdated
*/
--color-grey: #867e8e;
/* TODO: code block (remove this once fixed at void0 theme) */
--vp-code-color: #007d38;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving this to :root[data-theme="light"][data-variant="vitest"] { doesn't work, this is why I also add --vp-code-color: var(--vp-c-brand-1); at :root.dark:not([data-theme])[data-variant="vitest"], :root[data-theme="dark"][data-variant="vitest"] {; from time to time, changing styles.css doesn't reload, I need to restart VP dev server

/cc @brc_dd

Copy link
Copy Markdown
Member

@sheremet-va sheremet-va Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--vp-code-color is --vp-c-brand-1 which is --color-brand by default

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added :root[data-variant="vitest"]:not(.dark):not([data-theme="light"]) (missing entry, we use class="dark" for dark theme but no class for light theme) and moved the --vp-code-color there

@userquin
Copy link
Copy Markdown
Member Author

userquin commented Jan 16, 2026

Found some wcag-aa color contrast issues on light theme:

  • code blocks inside anchors
  • some shiki light styles
  • code blocks inside tips

We can solve these issues in a separate PR.

@userquin userquin requested a review from sheremet-va January 20, 2026 09:40
@sheremet-va
Copy link
Copy Markdown
Member

sheremet-va commented Jan 21, 2026

I feel like it makes more sense to fix this in the Void0 theme (at least what's in docs/.vitepress/theme/styles.css)

@sheremet-va
Copy link
Copy Markdown
Member

Or I guess only the gray color should be fixed in v0. Let's merge it for now

@sheremet-va sheremet-va merged commit 2a60cf8 into main Jan 21, 2026
10 checks passed
@sheremet-va sheremet-va deleted the userquin/docs-fix-wcag-aa-colors branch January 21, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants