fix(vite-node): unable to handle errors where sourcemap mapping empty #8071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-newman
force-pushed
the
blake.newman/console-error-source-map
branch
from
4a8c0a9 to
f1d1ca8
Compare
vitejs/vite#19226 introduced a change where by empty source mappings are not combined. As such when vitest has an internal error caused such as using jsdom feature that is not implemented which logs an error it tries to map the source map when the mapping is empty which results in an error such as: ``` Cannot read properties of undefined (reading 'map') ❯ VirtualConsole.<anonymous> node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/virtual-console.js:29:53 ❯ module.exports node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/browser/not-implemented.js:12:26 ❯ HTMLAudioElementImpl.load node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/living/nodes/HTMLMediaElement-impl.js:112:5 ❯ HTMLAudioElement.load node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/living/generated/HTMLMediaElement.js:109:34 ``` When the error originates from a file without source mapping such as `x.vue` it errors instead of logging original error.
blake-newman
force-pushed
the
blake.newman/console-error-source-map
branch
from
f1d1ca8 to
0634378
Compare
|
Looks like this could be related: |
hi-ogawa
reviewed
Jun 2, 2025
There was a problem hiding this comment.
Good catch. I think I have some idea how this goes wrong, but reproduction would be great 🙏 Is the error happening during new TraceMap({ mappings: '' })?
Also I'm not sure whether we should fix it here or maybe we can change Vite ssrTransform to return more robust map.
|
@hi-ogawa here is reproduction. Sorry took me a while to reproduce myself: https://github.com/blake-newman/vitest-dev-vitest-se4padzq Turns out it's specific to when using TSX |
6 tasks
hi-ogawa
approved these changes
Jun 6, 2025
sheremet-va
approved these changes
Jun 9, 2025
This was referenced Jun 17, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vitejs/vite#19226 introduced a change where by empty source mappings are not combined. As such when vitest has an internal error caused such as using jsdom feature that is not implemented which logs an error it tries to map the source map when the mapping is empty which results in an error such as:
When the error originates from a file without source mapping such as
x.vueit errors instead of logging original error.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.