Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,15 @@ All three programs can be made aware of Backup Engine and Backup Storage using t
<code>--external-decompressor "pigz -d -c"</code>
</td>
</tr>
<tr>
<td><code>external-decompressor-use-manifest</code></td>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citation: PR #19460 adds the --external-decompressor-use-manifest flag to address a security vulnerability. See go/vt/mysqlctl/compression.go for the flag registration and resolveExternalDecompressor() function implementation that handles the precedence logic. The flag help text in the PR explicitly warns about the security risk of trusting manifest decompressor commands.
View source

<td>
Allows the decompressor command stored in the backup manifest to be used at restore time.
This is disabled by default for security reasons: an attacker with write access to backup storage
could modify the manifest to execute arbitrary commands on the tablet as the Vitess user.
Only enable this flag if you trust your backup storage and understand the risks involved.
</td>
</tr>
<tr>
<td><code>file-backup-storage-root</code></td>
<td>For the <code>file</code> plugin, this identifies the root directory
Expand Down