Skip to content

Use relay log position in PRS while choosing the new primary#9270

Merged
GuptaManan100 merged 5 commits into
vitessio:mainfrom
planetscale:prs-use-relay-log
Nov 30, 2021
Merged

Use relay log position in PRS while choosing the new primary#9270
GuptaManan100 merged 5 commits into
vitessio:mainfrom
planetscale:prs-use-relay-log

Conversation

@GuptaManan100

Copy link
Copy Markdown
Contributor

Description

While choosing the new primary in PRS, we should be using the relay log position, if it is available. This PR makes that change and adds tests for it.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

This PR has been created on top of #9259, and it should be merged after it.

@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management release notes labels Nov 20, 2021

@deepthi deepthi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a nit.
I assume this needs to be rebased once #9259 is merged.

Comment thread go/vt/vtctl/reparentutil/util.go Outdated
@GuptaManan100

Copy link
Copy Markdown
Contributor Author

Yes, I'll rebase it once that PR is merged

@ajm188 ajm188 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit dddb996 into vitessio:main Nov 30, 2021
@GuptaManan100 GuptaManan100 deleted the prs-use-relay-log branch November 30, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlannedReparent improvements

3 participants