Skip to content

Don't return an error for CONN_ATTR (just log) #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Don't return an error for CONN_ATTR (just log) #4897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions go/mysql/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,10 +683,8 @@ func (l *Listener) parseClientHandshakePacket(c *Conn, firstTime bool, data []by

// Decode connection attributes send by the client
if clientFlags&CapabilityClientConnAttr != 0 {
var err error
_, _, err = parseConnAttrs(data, pos)
if err != nil {
return "", "", nil, err
if _, _, err := parseConnAttrs(data, pos); err != nil {
log.Warningf("Decode connection attributes send by the client: %v", err)
}
}

Expand Down