Skip to content

[main] Upgrade the Golang version to go1.26.4#20337

Merged
mattlord merged 1 commit into
mainfrom
upgrade-go-to-1.26.4-on-main
Jun 16, 2026
Merged

[main] Upgrade the Golang version to go1.26.4#20337
mattlord merged 1 commit into
mainfrom
upgrade-go-to-1.26.4-on-main

Conversation

@vitess-bot

@vitess-bot vitess-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This Pull Request bumps the Golang version to go1.26.4 and the bootstrap version to 57.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

cc @vitessio/release

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 16, 2026 14:50
@vitess-bot vitess-bot Bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build labels Jun 16, 2026
@vitess-bot vitess-bot Bot added the Benchmark me Add label to PR to run benchmarks label Jun 16, 2026
@vitess-bot vitess-bot Bot added Component: General Changes throughout the code base go labels Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vitess-bot

vitess-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@vitess-bot

vitess-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 16, 2026
@github-actions github-actions Bot added this to the v25.0.0 milestone Jun 16, 2026
@mattlord mattlord enabled auto-merge (squash) June 16, 2026 14:54
@promptless

promptless Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Promptless prepared a documentation update related to this change.

Triggered by PR #20337

The macOS build-from-source guide pinned go1.26.1 in its example Go install commands. Since this PR bumps the main toolchain to go1.26.4, the doc example is now stale — the suggestion updates those commands to go1.26.4.

Review: Update macOS build-from-source Go version example to go1.26.4

@arthurschreiber arthurschreiber removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 16, 2026
@mattlord mattlord merged commit 864607b into main Jun 16, 2026
196 of 205 checks passed
@mattlord mattlord deleted the upgrade-go-to-1.26.4-on-main branch June 16, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmark me Add label to PR to run benchmarks Component: Build/CI Component: Docker Component: General Changes throughout the code base go Type: CI/Build Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants