discovery: hold connMu when writing tabletHealthCheck health fields#20319
Open
netliomax25-code wants to merge 1 commit into
Open
discovery: hold connMu when writing tabletHealthCheck health fields#20319netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
Signed-off-by: netliomax25-code <netliomax25@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tabletHealthCheck.SimpleCopy(andconnectionLocked) readTarget,Serving,Stats,LastErrorandPrimaryTermStartTimeunderconnMu, butprocessResponse, the timeout branch ofcheckConn,closeConnectionandfinalizeConnwrite those same fields without holdingconnMu.SimpleCopyis reachable from another goroutine throughHealthCheck.GetTabletHealthByAliaswhile the per-tabletcheckConngoroutine is applying a streaming health update, sogo test -racereports a read/write race on those fields.connMuaround the field writes at all four sites, releasing it beforeSimpleCopyand before any connectionCloseso the lock is never held across network IO.The added regression test drives
processResponseandGetTabletHealthByAliasconcurrently and fails under-racewithout the change.Related Issue(s)
N/A
Checklist
Deployment Notes
None. Internal locking fix with no user-visible behavior change.
AI Disclosure