Skip to content

discovery: hold connMu when writing tabletHealthCheck health fields#20319

Open
netliomax25-code wants to merge 1 commit into
vitessio:mainfrom
netliomax25-code:healthcheck-connmu-lock
Open

discovery: hold connMu when writing tabletHealthCheck health fields#20319
netliomax25-code wants to merge 1 commit into
vitessio:mainfrom
netliomax25-code:healthcheck-connmu-lock

Conversation

@netliomax25-code

Copy link
Copy Markdown
Contributor

Description

  1. tabletHealthCheck.SimpleCopy (and connectionLocked) read Target, Serving, Stats, LastError and PrimaryTermStartTime under connMu, but processResponse, the timeout branch of checkConn, closeConnection and finalizeConn write those same fields without holding connMu.
  2. SimpleCopy is reachable from another goroutine through HealthCheck.GetTabletHealthByAlias while the per-tablet checkConn goroutine is applying a streaming health update, so go test -race reports a read/write race on those fields.
  3. Took connMu around the field writes at all four sites, releasing it before SimpleCopy and before any connection Close so the lock is never held across network IO.

The added regression test drives processResponse and GetTabletHealthByAlias concurrently and fails under -race without the change.

Related Issue(s)

N/A

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

None. Internal locking fix with no user-visible behavior change.

AI Disclosure

Signed-off-by: netliomax25-code <netliomax25@gmail.com>
Copilot AI review requested due to automatic review settings June 15, 2026 09:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added this to the v25.0.0 milestone Jun 15, 2026
@vitess-bot vitess-bot Bot added the NeedsWebsiteDocsUpdate What it says label Jun 15, 2026
@vitess-bot

vitess-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot Bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants