Skip to content

build(deps): bump the go group across 1 directory with 5 updates#20306

Merged
mattlord merged 2 commits into
mainfrom
dependabot/go_modules/go-dba8ac16d7
Jun 16, 2026
Merged

build(deps): bump the go group across 1 directory with 5 updates#20306
mattlord merged 2 commits into
mainfrom
dependabot/go_modules/go-dba8ac16d7

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 11, 2026

Copy link
Copy Markdown
Contributor

Bumps the go group with 4 updates in the / directory: golang.org/x/sys, github.com/aws/aws-sdk-go-v2, github.com/aws/aws-sdk-go-v2/config and github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager.

Updates golang.org/x/sys from 0.45.0 to 0.46.0

Commits

Updates github.com/aws/aws-sdk-go-v2 from 1.41.7 to 1.41.8

Commits

Updates github.com/aws/aws-sdk-go-v2/config from 1.32.18 to 1.32.19

Commits

Updates github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager from 0.2.0 to 0.2.1

Commits
  • d206334 Release 2020-10-26
  • 59290c5 bump SDK core version and name
  • 9984c37 update module go.sums
  • 36fde8a checkpoint for release metadata
  • 2a74240 tidy SDK module
  • 1aeb416 update hand written modules smithy-go dep
  • df7bd9a update endpoints
  • 5f0f033 update api models
  • 693e56c internal/repotools/cmd/makerelative: Support Relative Paths for Transitive De...
  • cb36c8d Merge pull request #851 from aws/r53cust-fix
  • Additional commits viewable in compare view

Updates github.com/aws/aws-sdk-go-v2/service/s3 from 1.102.0 to 1.102.1

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the go group with 4 updates in the / directory: [golang.org/x/sys](https://github.com/golang/sys), [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2), [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager](https://github.com/aws/aws-sdk-go-v2).


Updates `golang.org/x/sys` from 0.45.0 to 0.46.0
- [Commits](golang/sys@v0.45.0...v0.46.0)

Updates `github.com/aws/aws-sdk-go-v2` from 1.41.7 to 1.41.8
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@v1.41.7...v1.41.8)

Updates `github.com/aws/aws-sdk-go-v2/config` from 1.32.18 to 1.32.19
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.32.18...config/v1.32.19)

Updates `github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager` from 0.2.0 to 0.2.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@v0.2.0...config/v0.2.1)

Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.102.0 to 1.102.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.102.0...service/s3/v1.102.1)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-version: 0.46.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-version: 1.41.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.32.19
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
- dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager
  dependency-version: 0.2.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-version: 1.102.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go labels Jun 11, 2026
Copilot AI review requested due to automatic review settings June 11, 2026 19:13
@dependabot dependabot Bot requested a review from harshit-gangal as a code owner June 11, 2026 19:13
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Jun 11, 2026
@dependabot dependabot Bot added the go label Jun 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 11, 2026
@github-actions github-actions Bot added this to the v25.0.0 milestone Jun 11, 2026
@vitess-bot

vitess-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions Bot added the Type: Dependencies Dependency updates label Jun 11, 2026
@arthurschreiber

Copy link
Copy Markdown
Member

The AWS SDK bump is causing unit tests to fail.

@timvaillancourt timvaillancourt added Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 11, 2026
transfermanager v0.2.1 decoupled the multipart-vs-single upload decision
from PartSizeBytes into a separate MultipartUploadThreshold option
(default 16MiB). Since we only set PartSizeBytes, files between the part
size and 16MiB regressed to a single PutObject instead of multipart.

Set MultipartUploadThreshold to the part size to preserve the prior
behavior, where multipart kicks in above the configured part size.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber

Copy link
Copy Markdown
Member

Why the unit test failed after this bump

The feature/s3/transfermanager bump (v0.2.0 → v0.2.1) caused TestAddFileMultipartStats to fail. This is an intentional behavior change in the AWS SDK, not a bug in our code — but it does have a real consequence for backups, so I pushed a fix.

Root cause

In v0.2.0, the transfer manager decided between a single PutObject and a multipart upload based on PartSizeBytes:

r := io.LimitReader(u.in.Body, u.options.PartSizeBytes)
...
if int64(n) < u.options.PartSizeBytes { /* single upload */ }

In v0.2.1, that decision moved to a separate MultipartUploadThreshold option (default 16MiB):

r := io.LimitReader(u.in.Body, u.options.MultipartUploadThreshold)
...
if int64(n) < u.options.MultipartUploadThreshold { /* single upload */ }

We only set PartSizeBytes (5MiB default) and never set MultipartUploadThreshold, so it fell back to the new 16MiB default. The test's 6MiB object — which used to upload as multipart — now went out as a single PutObject, tripping the len(TimedIncrementCalls) > 1 assertion.

The practical effect beyond the test: any backup file between the part size and 16MiB that used to chunk now uploads single-shot.

Fix

Pin MultipartUploadThreshold to the part size so multipart kicks in above the configured part size, as before:

o.PartSizeBytes = partSizeBytes
o.MultipartUploadThreshold = partSizeBytes

This restores the prior behavior and respects the operator-facing --s3-backup-aws-min-partsize flag's intent. The existing test passes unchanged as the guard.

Diagnosis and fix by Claude Code.

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.04%. Comparing base (70c7a72) to head (4a53e16).
⚠️ Report is 325 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #20306       +/-   ##
===========================================
- Coverage   69.67%   68.04%    -1.63%     
===========================================
  Files        1614        3     -1611     
  Lines      216793      435   -216358     
===========================================
- Hits       151044      296   -150748     
+ Misses      65749      139    -65610     
Flag Coverage Δ
partial 68.04% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattlord mattlord merged commit a7f3ed2 into main Jun 16, 2026
112 checks passed
@mattlord mattlord deleted the dependabot/go_modules/go-dba8ac16d7 branch June 16, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base dependencies Pull requests that update a dependency file go Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants