[release-23.0] build: move dev tools into per-tool Go modules (#20293)

[vitess-bot]

Description

This is a backport of #20293

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[vitess-bot]

Hello @arthurschreiber, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 20296
git reset --hard origin/release-23.0
git cherry-pick -m 1 dc9b73d86da7113583a64f91b2d16ab2bd8b9780

[arthurschreiber]

Resolved the cherry-pick conflicts in 23cad92. This branch diverges from main quite a bit, so the resolution adapts the upstream change to release-23.0's tooling — the guiding rule was: keep release-23.0's behavior, adopt module pinning only where this branch used floating versions.

Kept release-23.0's mechanics:

• The vendored ./goyacc in sqlparser stays (go run ./goyacc -fo); dropped tools/goyacc/ and removed it from the dependabot config
• gofmt/go fmt stays everywhere — this branch never adopted gofumpt; dropped tools/gofumpt/ likewise
• No new Makefile lint/lint-fix targets (they don't exist on this branch)
• No yamllint step (this branch has no github: paths-filter, it would be dead code)
• build.env untouched (never had GOLANGCI_LINT_VER)

Adopted per-tool modules, re-pinned to this branch's versions with go 1.25.10:

• tools/golangci-lint at v2.0.2 (the version the git hook pinned; regenerated the module graph from scratch since main's v2.12.2 dependency set doesn't compile at v2.0.2)
• tools/goimports at x/tools v0.39.0 — an improvement for this branch, which installed goimports @latest in CI
• tools/gotestsum at v1.13.0 (the version already used via the root tool directive)
• codegen.GoImports keeps the gofmt -s -w step and now runs modfile-pinned goimports after it
• One adaptation outside the conflict markers: the CI "Install golangci-lint" step now reads the version from tools/golangci-lint/go.mod instead of hardcoding @v2.0.2 — dependabot now bumps that module, so a hardcoded CI version would silently drift
• go.mod tool block gets the three protoc plugins (the Makefile's proto rule now resolves them via go tool -n), with protoc-gen-go-grpc settling at v1.2.0 — the version the removed install_protoc-gen-go target pinned

Verified locally: go mod tidy clean in all modules, check_go_versions.sh, check_make_parser.sh, and check_make_sizegen.sh pass (sizegen output byte-identical through the new goimports path), golangci-lint v2.0.2 runs clean, full make build succeeds, and the pre-commit hook exercised the new modfile lint path during the resolution commit itself.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 20 changed files in this pull request and generated 1 comment.