Skip to content

docs: Add changelog entry for VTOrc InnoDBStalledPrimary analyzer#20170

Draft
promptless[bot] wants to merge 6 commits into
mainfrom
promptless/pr-20169-innodb-stalled-primary
Draft

docs: Add changelog entry for VTOrc InnoDBStalledPrimary analyzer#20170
promptless[bot] wants to merge 6 commits into
mainfrom
promptless/pr-20169-innodb-stalled-primary

Conversation

@promptless
Copy link
Copy Markdown
Contributor

@promptless promptless Bot commented May 23, 2026

Open this suggestion in Promptless to view citations and reasoning process

Documents the new InnoDBStalledPrimary analysis code in v25.0.0 that detects MySQL primaries wedged on an InnoDB latch and triggers Emergency Reparent Shard (ERS) recovery. Covers requirements (MySQL 8.0+, valid replicas), detection mechanism (MY-012985 warning), and the updated innodb_fatal_semaphore_wait_threshold configuration.

Trigger Events

Tip: Add or adjust Promptless's style guide in Agent Knowledge Base ✍️

@promptless
Add changelog entry for VTOrc InnoDBStalledPrimary analyzer
a41f139 
Documents the new InnoDBStalledPrimary analysis code that detects MySQL
primaries wedged on an InnoDB latch and triggers ERS recovery. Covers
requirements (MySQL 8.0+, valid replicas), detection mechanism (MY-012985
warning in performance_schema.error_log), and the updated
innodb_fatal_semaphore_wait_threshold configuration in bundled MySQL configs.

See PR #20169 for implementation details.
Copilot AI review requested due to automatic review settings May 23, 2026 01:04
promptless[bot]
promptless Bot commented May 23, 2026
View reviewed changes
Comment thread changelog/25.0/25.0.0/summary.md

The analyzer detects the stall around T=120s, giving ERS time to complete before `mysqld` would self-kill. Operators can override this setting via `EXTRA_MY_CNF`.

See [#20169](https://github.com/vitessio/vitess/pull/20169) for details.
Copy link
Copy Markdown
Contributor Author

@promptless promptless Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #20169 implements the InnoDBStalledPrimary analysis code in go/vt/vtorc/inst/analysis_problem.go, adds HasRecentInnoDBLongSemaphoreWait() to MysqlDaemon interface, wires it through FullStatus RPC, and updates innodb_fatal_semaphore_wait_threshold in bundled MySQL configs.

Source: #20169

Copilot AI reviewed May 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@promptless
Copy link
Copy Markdown
Contributor Author

promptless Bot commented May 23, 2026

I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed.

@github-actions github-actions Bot added this to the v25.0.0 milestone May 23, 2026
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 23, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented May 23, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions Bot added the Component: Documentation docs related issues/PRs label May 23, 2026
@promptless
Copy link
Copy Markdown
Contributor Author

promptless Bot commented May 23, 2026

I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed.

@promptless promptless Bot added Type: Documentation Component: VTOrc Vitess Orchestrator integration labels May 23, 2026
@promptless
Copy link
Copy Markdown
Contributor Author

promptless Bot commented May 23, 2026

I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed.

@promptless promptless Bot removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 23, 2026
@promptless
Copy link
Copy Markdown
Contributor Author

promptless Bot commented May 23, 2026

I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed.

Copilot AI review requested due to automatic review settings May 26, 2026 12:21
Copilot AI reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@promptless
Copy link
Copy Markdown
Contributor Author

promptless Bot commented May 26, 2026

I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed.

Copilot AI review requested due to automatic review settings May 26, 2026 14:07
Copilot AI reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Component: Documentation docs related issues/PRs Component: VTOrc Vitess Orchestrator integration Type: Documentation

Projects

None yet

Milestone

v25.0.0

Development

Successfully merging this pull request may close these issues.

1 participant