[release-23.0] tests: give vtctl/workflow tests their own port range (#20150)#20155
Open
vitess-bot[bot] wants to merge 2 commits into
Open
[release-23.0] tests: give vtctl/workflow tests their own port range (#20150)#20155vitess-bot[bot] wants to merge 2 commits into
vitess-bot[bot] wants to merge 2 commits into
Conversation
vitess-bot
Bot
added
Type: Bug
Component: VReplication
Backport
Contributor
Author
|
Hello @arthurschreiber, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace |
vitess-bot
Bot
requested review from
arthurschreiber,
beingnoble03,
rohit-nayak-ps,
shlomi-noach and
timvaillancourt
The conflict was a stylistic divergence: release-23.0 still uses `for i := 0; i < len(cells); i++` while main was modernized to `for i := range cells` by an unrelated PR. Keep the release-23.0 loop style and adopt the new startEtcd(client, peer) call from PR Signed-off-by: Arthur Schreiber <arthur@planetscale.com> #20150.
arthurschreiber
approved these changes
May 22, 2026
Comment on lines
+33
to
+35
| // Each port has its own constant; do not introduce ad-hoc `port + N` | ||
| // arithmetic at call sites or in this file. New entries must extend | ||
| // the range without overlapping any existing constant. |
| @@ -41,7 +42,7 @@ import ( | |||
| // behavior accidentally/uinintentionally. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #20150