Skip to content

[release-24.0] smartconnpool: avoid idle reopen stalls (#20079)#20134

Merged
arthurschreiber merged 1 commit into
release-24.0from
backport-20079-to-release-24.0
May 20, 2026
Merged

[release-24.0] smartconnpool: avoid idle reopen stalls (#20079)#20134
arthurschreiber merged 1 commit into
release-24.0from
backport-20079-to-release-24.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot Bot commented May 18, 2026

Description

This is a backport of #20079

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Copilot AI review requested due to automatic review settings May 18, 2026 22:07
@vitess-bot vitess-bot Bot requested a review from harshit-gangal as a code owner May 18, 2026 22:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vitess-bot vitess-bot Bot requested a review from arthurschreiber May 18, 2026 22:07
@github-actions github-actions Bot added this to the v24.0.2 milestone May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-24.0@df75a4f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
go/pools/smartconnpool/pool.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-24.0   #20134   +/-   ##
===============================================
  Coverage                ?   52.93%           
===============================================
  Files                   ?        8           
  Lines                   ?      920           
  Branches                ?        0           
===============================================
  Hits                    ?      487           
  Misses                  ?      433           
  Partials                ?        0           
Flag Coverage Δ
partial 52.93% <84.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber arthurschreiber merged commit 72388a1 into release-24.0 May 20, 2026
122 checks passed
@arthurschreiber arthurschreiber deleted the backport-20079-to-release-24.0 branch May 20, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants