Regenerate vtadmin protos.#20132
Merged
Merged
Conversation
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
mhamza15
approved these changes
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the generated VTAdmin JavaScript protobuf module to align with the current protobufjs dependency/module format used by the vtadmin web app (ESM), unblocking PR builds that currently fail on main.
Changes:
- Regenerates/updates the generated
vtadmin.jsproto output to use an ESM-compatibleprotobufjsimport. - Adjusts the protobufjs import path to the
minimal.jsentrypoint.
nickvanw
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This currently breaks all PR builds against
main. Seems like we didn't regenerate this file after the most recent dependency update.Related Issue(s)
Might have been caused by #20088
Checklist
Deployment Notes
AI Disclosure