Skip to content

Regenerate vtadmin protos.#20132

Merged
arthurschreiber merged 1 commit into
mainfrom
arthur/fix-vtadmin-protos
May 18, 2026
Merged

Regenerate vtadmin protos.#20132
arthurschreiber merged 1 commit into
mainfrom
arthur/fix-vtadmin-protos

Conversation

@arthurschreiber
Copy link
Copy Markdown
Member

@arthurschreiber arthurschreiber commented May 18, 2026

Description

This currently breaks all PR builds against main. Seems like we didn't regenerate this file after the most recent dependency update.

Related Issue(s)

Might have been caused by #20088

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Copilot AI review requested due to automatic review settings May 18, 2026 21:18
@github-actions github-actions Bot added this to the v25.0.0 milestone May 18, 2026
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 18, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented May 18, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the generated VTAdmin JavaScript protobuf module to align with the current protobufjs dependency/module format used by the vtadmin web app (ESM), unblocking PR builds that currently fail on main.

Changes:

  • Regenerates/updates the generated vtadmin.js proto output to use an ESM-compatible protobufjs import.
  • Adjusts the protobufjs import path to the minimal.js entrypoint.

@arthurschreiber arthurschreiber removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 18, 2026
@arthurschreiber arthurschreiber enabled auto-merge (squash) May 18, 2026 21:34
@arthurschreiber arthurschreiber merged commit 4d6bceb into main May 18, 2026
125 of 134 checks passed
@arthurschreiber arthurschreiber deleted the arthur/fix-vtadmin-protos branch May 18, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants