trace: remove deprecated OpenTracing backends#19939
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19939 +/- ##
===========================================
- Coverage 69.67% 48.91% -20.76%
===========================================
Files 1614 6 -1608
Lines 216793 462 -216331
===========================================
- Hits 151044 226 -150818
+ Misses 65749 236 -65513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
|
Promptless prepared a documentation update related to this change. Triggered by vitessio/vitess#19939 Updated VTAdmin reference docs to replace deprecated Review: Remove stale OpenTracing references from v25 VTAdmin docs |
|
Website PR: vitessio/website#2100 |
mattlord
left a comment
There was a problem hiding this comment.
Thanks, @timvaillancourt ! ❤️
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Description
This completes the v25 OpenTracing cleanup announced in #19619. The
opentracing-jaegerandopentracing-datadogbackends were deprecated in v24 with a migration path to--tracer opentelemetry— this removes them so we're running a single tracing implementationDeleted
opentracing.go,plugin_jaeger.go,plugin_datadog.go,logger.go(and their tests) fromgo/trace/. Also migratedvtadmin/grpcserverwhich was the only place still usingopentracing.GlobalTracer()directly — it now usestrace.AddGrpcServerOptions()like everything elseDependencies dropped:
opentracing-go,opentracing-contrib/go-grpc,uber/jaeger-client-go,uber/jaeger-lib,dd-trace-go.v1and their transitive depsBreaking:
--tracer opentracing-jaegerand--tracer opentracing-datadogno longer work. The following flags are also removed:--jaeger-agent-host,--tracing-sampling-type,--datadog-agent-host,--datadog-agent-port,--datadog-trace-debug-mode. TheJAEGER_SAMPLER_PARAMenv var no longer sets--tracing-sampling-rateCheckout that
go.modcleanup (8 x direct/39 indirect dependencies 🧹) 😮!Related Issue(s)
tracing.mddocs to v25 website#2099Checklist
Deployment Notes
Users running
--tracer opentracing-jaegeror--tracer opentracing-datadogmust switch to--tracer opentelemetrybefore upgrading to v25. The deprecation warning added in v24 (#19619) pointed to the migration pathAI Disclosure
This PR was written primarily by Claude Code — I provided direction on the cleanup scope. Claude also prepared this PR summary