Skip to content

[release-23.0] workflow: finish switch traffic after post-journal cancel (#19672)#19682

Merged
nickvanw merged 1 commit into
release-23.0from
backport-19672-to-release-23.0
Mar 20, 2026
Merged

[release-23.0] workflow: finish switch traffic after post-journal cancel (#19672)#19682
nickvanw merged 1 commit into
release-23.0from
backport-19672-to-release-23.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot Bot commented Mar 20, 2026

Description

This is a backport of #19672

Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
Copilot AI review requested due to automatic review settings March 20, 2026 10:42
@vitess-bot vitess-bot Bot added the Type: Bug label Mar 20, 2026
@vitess-bot vitess-bot Bot requested a review from mattlord as a code owner March 20, 2026 10:42
@vitess-bot vitess-bot Bot requested review from nickvanw and removed request for Copilot March 20, 2026 10:42
@github-actions github-actions Bot added this to the v23.0.4 milestone Mar 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.74%. Comparing base (550459d) to head (641aefa).
⚠️ Report is 8 commits behind head on release-23.0.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/server.go 75.00% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-23.0   #19682       +/-   ##
=================================================
+ Coverage         69.45%   70.74%    +1.29%     
=================================================
  Files              1607       22     -1585     
  Lines            215090     7528   -207562     
=================================================
- Hits             149397     5326   -144071     
+ Misses            65693     2202    -63491     
Flag Coverage Δ
partial 70.74% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickvanw nickvanw enabled auto-merge (squash) March 20, 2026 11:10
@nickvanw nickvanw merged commit 0ff61a2 into release-23.0 Mar 20, 2026
120 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant